Skip to content

Conversation

@ansys-pwalters
Copy link
Collaborator

Description

Added time filtering to importThermalSignal API.

Issue linked

618

Checklist:

  • [] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • [] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running
  • [] Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansys-pwalters ansys-pwalters linked an issue Aug 1, 2025 that may be closed by this pull request
# Conflicts:
#	src/ansys/sherlock/core/lifecycle.py
#	src/ansys/sherlock/core/types/lifecycle_types.py
#	tests/test_lifecycle.py
@github-actions github-actions bot added the testing Anything related to tests label Aug 1, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.43%. Comparing base (76171e6) to head (fa4543c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   61.40%   61.43%   +0.02%     
==========================================
  Files          22       22              
  Lines        5760     5764       +4     
==========================================
+ Hits         3537     3541       +4     
  Misses       2223     2223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansys-pwalters ansys-pwalters added this to the 2026 R1 milestone Aug 1, 2025
@ansjmoody ansjmoody self-requested a review August 1, 2025 16:15
@ansys-pwalters ansys-pwalters merged commit 4f53c24 into main Aug 12, 2025
27 checks passed
@ansys-pwalters ansys-pwalters deleted the thermalSignal0801 branch August 12, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ... Update API: Add time filtering to import thermal signal

4 participants