Skip to content

Conversation

@ansjdudkows
Copy link
Contributor

@ansjdudkows ansjdudkows commented Aug 7, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansjdudkows ansjdudkows added this to the 2026 R1 milestone Aug 7, 2025
@ansjdudkows ansjdudkows self-assigned this Aug 7, 2025
@ansjdudkows ansjdudkows added testing Anything related to tests dependencies Related with project dependencies enhancement New features or code improvements documentation Improvements or additions to documentation maintenance Package and maintenance related labels Aug 7, 2025
@github-actions github-actions bot removed dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 7, 2025
@ansjdudkows ansjdudkows added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 8, 2025
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 65.16854% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.48%. Comparing base (4f53c24) to head (32c1815).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/layer_types.py 66.66% 28 Missing ⚠️
src/ansys/sherlock/core/layer.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
+ Coverage   61.43%   61.48%   +0.05%     
==========================================
  Files          22       22              
  Lines        5764     5853      +89     
==========================================
+ Hits         3541     3599      +58     
- Misses       2223     2254      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 8, 2025
@ansjdudkows ansjdudkows added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 8, 2025
@github-actions github-actions bot removed dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 8, 2025
@ansjdudkows ansjdudkows marked this pull request as ready for review August 8, 2025 13:51
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 8, 2025
@ansjdudkows ansjdudkows requested a review from anskhanson August 8, 2025 15:50
@ansjdudkows ansjdudkows enabled auto-merge (squash) August 8, 2025 17:41
@ansjdudkows ansjdudkows merged commit 65dd6aa into main Aug 15, 2025
26 checks passed
@anskhanson anskhanson deleted the joe/updateICT branch August 15, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants