Skip to content

Conversation

@ansys-pwalters
Copy link
Collaborator

Description

Updated rainflow cycle binning to use separate binning parameters for range, mean, and dwell.

Issue linked

Resolves #627

Checklist:

  • [y] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [y] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [y] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [na] Add new classes to rst files, located at: \doc\source\api
  • [y] Generate documentation
  • [y] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [tbd] Check that test code coverage is at least 80% when Sherlock is running
  • [y] Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansys-pwalters ansys-pwalters added this to the 2026 R1 milestone Sep 3, 2025
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Sep 3, 2025
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.54%. Comparing base (9fa3005) to head (f403f04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   61.51%   61.54%   +0.02%     
==========================================
  Files          22       22              
  Lines        5878     5882       +4     
==========================================
+ Hits         3616     3620       +4     
  Misses       2262     2262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansys-pwalters ansys-pwalters merged commit 20293f5 into main Sep 10, 2025
27 checks passed
@ansys-pwalters ansys-pwalters deleted the thermalSignal0903 branch September 10, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ... Add ... Update API: Add separate binning options for importing thermal signal

4 participants