Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Description

Added APIs: saveHarmonicProfile(), saveRandomVibeProfile(), saveShockPulseProfile() and saveThermalProfile()

Issue linked

#636 #637 #638 #639

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added this to the 2026 R1 milestone Sep 11, 2025
@ansnfernand ansnfernand self-assigned this Sep 11, 2025
@ansnfernand ansnfernand added the enhancement New features or code improvements label Sep 11, 2025
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Sep 11, 2025
dependabot bot and others added 6 commits September 15, 2025 10:59
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: Keith Hanson <122566160+anskhanson@users.noreply.github.com>
…ShockPulseProfile() and saveThermalProfile()
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Sep 15, 2025
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 69.30693% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.66%. Comparing base (afb58d7) to head (7d01418).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/lifecycle.py 26.47% 25 Missing ⚠️
src/ansys/sherlock/core/types/lifecycle_types.py 93.54% 4 Missing ⚠️
src/ansys/sherlock/core/errors.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   61.54%   61.66%   +0.12%     
==========================================
  Files          22       22              
  Lines        5882     5982     +100     
==========================================
+ Hits         3620     3689      +69     
- Misses       2262     2293      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansnfernand ansnfernand merged commit 2c53f13 into main Sep 15, 2025
27 checks passed
@ansnfernand ansnfernand deleted the saveProfilesAPI branch September 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add save_thermal_profile() Add save_shock_pulse_profile() Add save_random_vibe_profile() Add save_harmonic_profile()

4 participants