Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Description

Added APIs delete_event() and delete_phase()

Issue linked

#646 #647

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added this to the 2026 R1 milestone Sep 16, 2025
@ansnfernand ansnfernand self-assigned this Sep 16, 2025
@ansnfernand ansnfernand added the enhancement New features or code improvements label Sep 16, 2025
This was linked to issues Sep 16, 2025
@github-actions github-actions bot added the testing Anything related to tests label Sep 16, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 16, 2025
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 61.70213% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.66%. Comparing base (2c53f13) to head (237d98b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/lifecycle.py 22.22% 14 Missing ⚠️
src/ansys/sherlock/core/errors.py 60.00% 2 Missing ⚠️
src/ansys/sherlock/core/types/lifecycle_types.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   61.66%   61.66%           
=======================================
  Files          22       22           
  Lines        5982     6029   +47     
=======================================
+ Hits         3689     3718   +29     
- Misses       2293     2311   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansnfernand ansnfernand requested review from ansys-pwalters and removed request for ansjmoody October 10, 2025 14:25
@ansnfernand ansnfernand merged commit 74eeb99 into main Oct 14, 2025
27 checks passed
@ansnfernand ansnfernand deleted the deleteAPIs branch October 14, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add delete_phase() Add delete_event()

4 participants