Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

@ansnfernand ansnfernand commented Oct 30, 2025

Description

Deprecated APIs:
Stackup service: ListLaminateThicknessUnits
Lifecycle service: ListAmplUnits, ListShockLoadUnits

P.S:
ListFreqUnits (not found in PySherlock)
ListTempUnits (not found in PySherlock)

Removed previous deprecated APIs:
SherlockCommonService: getSolders
SherlockPartsService: getPartLocation

Issue linked

#293 #663

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

Deprecated APIs:
Stackup service: ListLaminateThicknessUnits
Lifecycle service: ListAmplUnits, ListShockLoadUnits

Removed previous deprecated APIs:
SherlockCommonService: getSolders
SherlockPartsService: getPartLocation
@ansnfernand ansnfernand added this to the 2026 R1 milestone Oct 30, 2025
@ansnfernand ansnfernand self-assigned this Oct 30, 2025
@ansnfernand ansnfernand added the maintenance Package and maintenance related label Oct 30, 2025
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation and removed maintenance Package and maintenance related labels Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.79%. Comparing base (74eeb99) to head (9061a07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   61.66%   61.79%   +0.12%     
==========================================
  Files          22       22              
  Lines        6029     5983      -46     
==========================================
- Hits         3718     3697      -21     
+ Misses       2311     2286      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansnfernand ansnfernand enabled auto-merge (squash) October 30, 2025 15:44
@ansnfernand ansnfernand merged commit bbc9ffa into main Nov 7, 2025
31 checks passed
@ansnfernand ansnfernand deleted the deprecateAPIs branch November 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove previous deprecated APIs Remove calling APIs for returning units for specific types

4 participants