Skip to content

Chore/bring over code from old repo #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Dec 27, 2023
Merged

Chore/bring over code from old repo #11

merged 32 commits into from
Dec 27, 2023

Conversation

@tmpbeing
Copy link
Collaborator

@tmpbeing tmpbeing commented Dec 22, 2023 •
edited
Loading

Brings the code from the old repo with some doc updates, linting and github actions.

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Dec 22, 2023
@tmpbeing tmpbeing force-pushed the chore/bring-over-code-from-old-repo branch 3 times, most recently from 7c8eacb to fe4cff3 Compare December 25, 2023 19:05
@tmpbeing tmpbeing force-pushed the chore/bring-over-code-from-old-repo branch from fe4cff3 to 55a6395 Compare December 25, 2023 19:15
@tmpbeing tmpbeing marked this pull request as ready for review December 27, 2023 08:40
jorgepiloto
jorgepiloto requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @tmpbeing! I just left some minor comments and suggestions but everything looks very solid. Congrats! 🚀

jorgepiloto
jorgepiloto approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only jobs left in the CI/CD are the release jobs. You can add for the moment the ones publishing to the private PyPI and GitHub.

@tmpbeing tmpbeing merged commit f37c76f into main Dec 27, 2023
@tmpbeing tmpbeing deleted the chore/bring-over-code-from-old-repo branch December 27, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

@Revathyvenugopal162 Revathyvenugopal162 Awaiting requested review from Revathyvenugopal162

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmpbeing @jorgepiloto