Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Feature merge master #23743

Merged
merged 27 commits into from
Apr 29, 2020
Merged

chore: Feature merge master #23743

merged 27 commits into from
Apr 29, 2020

Conversation

xrkffgg and others added 26 commits April 27, 2020 21:40
* docs: optimize site of components 1

* fix: lint

* fix: use space

* fix: snap

* revert: button demo

* fix snap
* fix: Table demo dynamic settings pagination

* fix test
* fix: Table pagination postion ts typo

* fix
* improve custom theme import path

* reduce npm package size
* fix: remove Button type danger in TypeScript

close #23708

* docs: fix Table dataSource type in document

close #23697

* add warning about type="danger"

* reverse button type warning logic
* ✅ fix test case for RangePicker presetted ranges

* 🆙 upgrade simple-git
* scriptUrl新增数组类型支持,增加文档说明,修改@ant-design/icons最低版本号

* 增加scriptUrl支持数组的代码演示,增加类型说明

* Icon 修改代码演示标题,补充文档

* 根据建议修改文档格式

* 增加scriptUrl为数组时候的覆盖关系说明

* 修改覆盖说明文案
* fix: Table crash when pageSize is undefined

* test case

* fix test case
* style: add divider rtl support

* add base
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 29, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80017a0:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #23743 into feature will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #23743      +/-   ##
===========================================
+ Coverage    98.50%   98.53%   +0.02%     
===========================================
  Files          363      363              
  Lines         7236     7247      +11     
  Branches      2014     2007       -7     
===========================================
+ Hits          7128     7141      +13     
+ Misses         108      106       -2     
Impacted Files Coverage Δ
components/page-header/index.tsx 100.00% <ø> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/date-picker/PickerTag.tsx 100.00% <100.00%> (+100.00%) ⬆️
components/divider/index.tsx 100.00% <100.00%> (ø)
components/pagination/Pagination.tsx 100.00% <100.00%> (ø)
...omponents/table/hooks/useFilter/FilterDropdown.tsx 96.15% <100.00%> (+0.10%) ⬆️
components/table/hooks/usePagination.ts 100.00% <100.00%> (ø)
components/tag/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14417f1...80017a0. Read the comment docs.

@zombieJ zombieJ merged commit 7f347ec into feature Apr 29, 2020
@zombieJ zombieJ deleted the feature-merge-master branch April 29, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants