Add insert, remove and update methods to multi_index (and index)#179
Merged
Add insert, remove and update methods to multi_index (and index)#179
Conversation
dimas1185
reviewed
May 16, 2023
dimas1185
approved these changes
May 17, 2023
Contributor
dimas1185
left a comment
There was a problem hiding this comment.
please address @jolly-fellow comments, not critical but will reduce verbosity
jolly-fellow
approved these changes
May 18, 2023
Contributor
|
Note:start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #135
Add insert, remove and update methods to multi_index
API Changes
For multi_index there are 3 new methods: insert (alias for emplace), remove (alias for erase), update (alias for modify).
Documentation Additions
If there is documentation for multi_index 3 new methods should be added. It might be in separate repo
docs.