Skip to content
This repository was archived by the owner on Mar 29, 2020. It is now read-only.

Commit 5f3cefc

Browse files
committed
fix(all): loosen up some rules
1 parent 208793f commit 5f3cefc

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

packages/eslint-config-react/base.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ module.exports = {
9595
'react/no-unused-state': 'error',
9696
'react/no-will-update-set-state': 'error',
9797
'react/prefer-es6-class': ['error', 'always'],
98-
'react/prefer-stateless-function': 'error',
98+
'react/prefer-stateless-function': 'off',
9999
'react/prop-types': [
100100
'off',
101101
{ignore: [], customValidators: [], skipUndeclared: false},
@@ -115,7 +115,7 @@ module.exports = {
115115
'instance-variables',
116116
'lifecycle',
117117
'/^handle.+$/',
118-
'/^(get|set)(?!(InitialState$|DefaultProps$|ChildContext$|InitialProps$)).+$/',
118+
'/^(is|get|set)(?!(InitialState$|DefaultProps$|ChildContext$|InitialProps$)).+$/',
119119
'everything-else',
120120
'/^render.+$/',
121121
'render',

packages/eslint-config-react/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ module.exports = {
1212
},
1313
},
1414
rules: {
15-
// https://github.com/evcohen/eslint-plugin-jsx-a11y
16-
'jsx-a11y/lang': 'error',
1715
// https://github.com/benmosher/eslint-plugin-import
1816
'import/extensions': [
1917
'error',
@@ -25,5 +23,7 @@ module.exports = {
2523
'web.jsx': 'never',
2624
},
2725
],
26+
// https://github.com/evcohen/eslint-plugin-jsx-a11y
27+
'jsx-a11y/lang': 'error',
2828
},
2929
};

packages/eslint-config-react/native.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ module.exports = {
3838
'native.jsx': 'never',
3939
},
4040
],
41+
// https://github.com/evcohen/eslint-plugin-jsx-a11y
42+
'jsx-a11y/accessible-emoji': 'off',
4143
// https://github.com/Intellicode/eslint-plugin-react-native
4244
'react-native/no-color-literals': 'error',
4345
'react-native/no-inline-styles': 'error',

packages/eslint-config/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module.exports = {
1010
'implicit-arrow-linebreak': 'off', // not necessary with prettier
1111
'max-depth': ['error', {max: 4}],
1212
'max-nested-callbacks': ['error', {max: 3}],
13-
'max-params': ['error', {max: 3}],
13+
'max-params': ['error', {max: 4}],
1414
'max-statements-per-line': ['error', {max: 1}],
1515
'newline-before-return': 'error',
1616
'no-compare-neg-zero': 'error',

0 commit comments

Comments
 (0)