DROID-4113 Widgets | Fixes drag-and-drop ID collision issues in widget sections #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes drag-and-drop ID collision issues in widget sections by introducing composite keys that include section type information, ensuring uniqueness across different widget sections (PINNED, TYPES, etc.).
Key changes:
- Introduced
compositeKey()andextractWidgetId()extension functions to manage unique widget identifiers - Refactored duplicate gesture handling code into reusable
ReorderableItemModifierandLongPressWithSlopDetectorcomponents - Added optimistic UI updates with rollback mechanism for type widget reordering
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WidgetView.kt | Added compositeKey() and extractWidgetId() extension functions with comprehensive documentation |
| WidgetViewExtensionTest.kt | New test file with extensive coverage for the extension functions, including edge cases and roundtrip tests |
| ReorderableItemModifier.kt | Extracted reusable modifier function for reorderable items, consolidating duplicate code |
| LongPressWithSlopDetector.kt | Extracted custom drag gesture detector into standalone class for reusability |
| HomeScreenViewModel.kt | Added optimistic updates and rollback logic for type widget reordering to improve UI responsiveness |
| WidgetsScreen.kt | Updated to extract widget IDs from composite keys during drag operations |
| WidgetSection.kt | Updated to use composite keys for LazyList items and replaced inline code with extracted reusable components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
konstantiniiv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?