DROID-3951 Membership | New tiers ui #2963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the membership tier UI mapping logic from an ID-based approach to a color-based approach, simplifying the codebase and making it more maintainable by eliminating hardcoded tier ID constants.
- Replaced ID-based tier resource mapping with color-based mapping using
CoverColorenum codes - Removed unused tier ID constants (
FREE_ID,PLUS_ID,PLUS_MONTHLY_ID,PRO_ID,PRO_MONTHLY_ID,ULTRA_ID,ULTRA_MONTHLY_ID) - Consolidated duplicate mapping logic into a single reusable
getIconsForColor()function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
payments/src/main/java/com/anytypeio/anytype/payments/screens/TierPreviewView.kt |
Refactored tier-to-resource mapping functions from ID-based switch statements to color-based logic using a new helper function, significantly reducing code duplication and complexity |
core-models/src/main/java/com/anytypeio/anytype/core_models/membership/MembershipConstants.kt |
Removed unused tier ID constants that are no longer needed with the new color-based mapping approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?