Skip to content

Conversation

@mgolovko
Copy link
Collaborator

No description provided.

@mgolovko mgolovko requested a review from a team as a code owner October 30, 2025 09:06
@claude
Copy link
Contributor

claude bot commented Oct 30, 2025

Bugs/Issues

ChatViewModel.swift:658 - Unbounded async loops with no cancellation mechanism will continue running after view model deallocation

ChatViewModel.swift:233 - Silent subscription failures: Using _ = discards all results and errors will be ignored

ChatViewModel.swift:658 - Missing @mainactor enforcement for UI state updates in async loops (the old .assign(to:) automatically handled main thread dispatch)


🚨 Major Issues - Address async subscription lifecycle and error handling

Base automatically changed from ios-5388-migrate-chat-coordinator-chat-view-to-observable to develop October 30, 2025 10:39
@mgolovko mgolovko merged commit 0622bea into develop Oct 30, 2025
13 checks passed
@mgolovko mgolovko deleted the ios-5388-migrate-chat-coordinator-chat-view-to-observable-2 branch October 30, 2025 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants