Add version/effect dropdowns and dynamic title to Matrix Mode UI #66
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ | |
| * along with controls for the screensaver mode functionality. | ||
| */ | ||
|
|
||
| import { getAvailableModes, getAvailableEffects } from "./config.js"; | ||
|
|
||
| export default class ModeDisplay { | ||
| constructor(config = {}) { | ||
| this.config = { | ||
|
|
@@ -21,8 +23,9 @@ export default class ModeDisplay { | |
| this.modeManager = null; | ||
| this.callbacks = { | ||
| toggleScreensaver: [], | ||
| changeSwitchInterval: [], | ||
| versionChange: [], | ||
| effectChange: [], | ||
| }; | ||
|
|
||
| this.init(); | ||
|
|
@@ -65,15 +68,31 @@ export default class ModeDisplay { | |
| this.element.className = "mode-display"; | ||
| this.element.style.cssText = this.getBaseStyles(); | ||
|
|
||
| const availableVersions = getAvailableModes(); | ||
| const availableEffects = getAvailableEffects(); | ||
|
|
||
| const versionOptions = availableVersions.map((v) => `<option value="${v}">${this.formatModeName(v)}</option>`).join(""); | ||
| const effectOptions = availableEffects.map((e) => `<option value="${e}">${this.formatModeName(e)}</option>`).join(""); | ||
|
|
||
| this.element.innerHTML = ` | ||
| <div class="mode-header" style="cursor: pointer; padding: 8px; border-bottom: 1px solid rgba(0, 255, 0, 0.2); margin-bottom: 8px; display: flex; justify-content: space-between; align-items: center;"> | ||
| <span class="mode-title">Matrix Mode</span> | ||
| <span class="toggle-icon">◐</span> | ||
| </div> | ||
| <div class="mode-content" style="display: none;"> | ||
| <div class="current-mode" style="margin-bottom: 10px; padding: 5px 0;"> | ||
| <div class="mode-version" style="font-weight: bold; margin-bottom: 5px;"> | ||
| <label style="display: block; font-size: 10px; margin-bottom: 2px;">Version:</label> | ||
| <select class="version-select" style="width: 100%; background: rgba(0, 255, 0, 0.1); border: 1px solid rgba(0, 255, 0, 0.3); color: #00ff00; font-family: monospace; font-size: 10px; padding: 3px; border-radius: 3px;"> | ||
| ${versionOptions} | ||
| </select> | ||
| </div> | ||
| <div class="mode-effect" style="margin-bottom: 5px;"> | ||
| <label style="display: block; font-size: 10px; margin-bottom: 2px;">Effect:</label> | ||
| <select class="effect-select" style="width: 100%; background: rgba(0, 255, 0, 0.1); border: 1px solid rgba(0, 255, 0, 0.3); color: #00ff00; font-family: monospace; font-size: 10px; padding: 3px; border-radius: 3px;"> | ||
| ${effectOptions} | ||
| </select> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="mode-controls" style="border-top: 1px solid rgba(0, 255, 0, 0.2); padding-top: 8px;"> | ||
|
|
@@ -94,10 +113,6 @@ export default class ModeDisplay { | |
| </select> | ||
| </label> | ||
| </div> | ||
| <button class="switch-mode-btn" style="width: 100%; padding: 4px; background: rgba(0, 255, 0, 0.2); border: 1px solid rgba(0, 255, 0, 0.3); color: #00ff00; font-family: monospace; font-size: 9px; border-radius: 3px; cursor: pointer; margin-top: 5px;"> | ||
| Switch Mode Now | ||
| </button> | ||
|
|
@@ -184,6 +199,18 @@ export default class ModeDisplay { | |
| this.toggleExpanded(); | ||
| }); | ||
|
|
||
| // Version dropdown change | ||
| const versionSelect = this.element.querySelector(".version-select"); | ||
| versionSelect.addEventListener("change", (e) => { | ||
| this.emit("versionChange", e.target.value); | ||
| }); | ||
|
|
||
| // Effect dropdown change | ||
| const effectSelect = this.element.querySelector(".effect-select"); | ||
| effectSelect.addEventListener("change", (e) => { | ||
| this.emit("effectChange", e.target.value); | ||
| }); | ||
|
|
||
| // Screensaver toggle | ||
| const screensaverToggle = this.element.querySelector(".screensaver-toggle"); | ||
| screensaverToggle.addEventListener("change", (e) => { | ||
|
|
@@ -198,12 +225,6 @@ export default class ModeDisplay { | |
| this.updateNextSwitchTime(); | ||
| }); | ||
|
|
||
| // Interval selection | ||
| const intervalSelect = this.element.querySelector(".interval-select"); | ||
| intervalSelect.addEventListener("change", (e) => { | ||
|
|
@@ -320,14 +341,14 @@ export default class ModeDisplay { | |
| if (!this.modeManager) return; | ||
|
|
||
| const modeInfo = this.modeManager.getModeInfo(); | ||
| const versionSelect = this.element.querySelector(".version-select"); | ||
| const effectSelect = this.element.querySelector(".effect-select"); | ||
|
|
||
| if (versionSelect) { | ||
| versionSelect.value = modeInfo.version; | ||
| } | ||
| if (effectSelect) { | ||
| effectSelect.value = modeInfo.effect; | ||
| } | ||
|
|
||
| this.updateNextSwitchTime(); | ||
|
|
@@ -355,24 +376,30 @@ export default class ModeDisplay { | |
| /** | ||
| * Set toggle states | ||
| */ | ||
| setToggleStates(screensaverEnabled, switchInterval = 600000) { | ||
| const screensaverToggle = this.element.querySelector(".screensaver-toggle"); | ||
| const intervalSelect = this.element.querySelector(".interval-select"); | ||
|
|
||
| if (screensaverToggle) { | ||
| screensaverToggle.checked = screensaverEnabled; | ||
| } | ||
| if (intervalSelect) { | ||
| intervalSelect.value = switchInterval.toString(); | ||
| } | ||
|
|
||
| this.updateNextSwitchTime(); | ||
| } | ||
|
|
||
| /** | ||
| * Format mode name for display | ||
| */ | ||
| formatModeName(name) { | ||
| return name | ||
| .split(/(?=[A-Z])|[_-]/) // Split on camelCase, underscores, and hyphens | ||
| .map((word) => word.charAt(0).toUpperCase() + word.slice(1).toLowerCase()) | ||
| .join(" "); | ||
| } | ||
|
Comment on lines
+396
to
+401
There was a problem hiding this comment. The |
||
|
|
||
| /** | ||
| * Add event listener | ||
| */ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
formatNamefunction duplicates the same logic asformatModeNamein mode-manager.js and mode-display.js. This code duplication creates maintenance overhead. Consider importing a shared utility function instead of defining this inline.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback