ARTEMIS-1182: Add / Port in support for JNDIReferenceFactory

[michaelandrepearce]

and JNDIStorable

• Add clones/copies of these class's from Qpid (though identical to ActiveMQ 5.x also) to support this.

---->

It seems Artemis is missing some class's needed to support tomcat context resource setup via jndi

https://stackoverflow.com/questions/41846374/connecting-tomcat-to-standalone-artemis-broker-via-jndi

this is present in ActiveMQ 5.x and also in QPID JMS

https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/jndi/JNDIReferenceFactory.java

https://github.com/apache/qpid-jms/blob/master/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JNDIReferenceFactory.java

[michaelandrepearce]

again build output says success, jenkins icon is orange, meaning success of this build.

[michaelandrepearce]

did a rebuild by force pushing comment change, all seems green.

[Spaction]

This still does not work correctly.
Things need to extend the JNDIStorable object in order for the factory to work.

It would seems the concept of this was with the JNDIBaseStorable(https://activemq.apache.org/maven/apidocs/org/apache/activemq/jndi/JNDIBaseStorable.html) object of ActiveMQ which has 2 subclasses: ActiveMQConnectionFactory, ActiveMQDestination

For this to correctly work i believe the 2 subclasses on Artemis's side needs to extend the JNDIStorable object.

[clebertsuconic]

@Spaction better to talk about this on the dev list? this is an old PR.

[Spaction]

@clebertsuconic , no idea where that is or really anything about gitHub. I'm not a contributor to this project, just have been stuck trying to migrate from an ActiveMQ instance to an Artemis one and this is my entire reason for being stuck for a week.

[clebertsuconic]

@Spaction github is not the place to ask question.. the user's list is for both activemq and activemq-artemis:

http://activemq.apache.org/discussion-forums.html

[michaelandrepearce]

I can look at this, I think I know what @Spaction is needing. @Spaction if I make some changes in a private branch next week would you be able to build and check it solves your issue?

[Spaction]

@michaelandrepearce I should be able to at any point next week. Any logging added can also be sent back.

[jbertram]

For future reference, instead of commenting on a PR that has been closed for awhile you can use one of the ActiveMQ mailing lists. The "user" list is probably the one you'd want to use, although the "dev" list would be fine as well. Either of these can be used by anybody in the community, not just contributors. Perhaps if you could explain more fully your use-case and your problem someone else in the community could lend a hand.