Skip to content

ARTEMIS-1502 added addressMemorySize and paging info to addresslist #1643

Closed
pgfox wants to merge 1 commit intoapache:masterfrom
pgfox:address_view_changes
Closed

ARTEMIS-1502 added addressMemorySize and paging info to addresslist #1643
pgfox wants to merge 1 commit intoapache:masterfrom
pgfox:address_view_changes

Conversation

@pgfox
Copy link
Copy Markdown
Contributor

@pgfox pgfox commented Nov 6, 2017

Added addressMemorySize, isPaging, numberOfPages, BytesPerPage to the address summary in the addresses panel in the web console. This allows addresses to be filtered by those attributes in the web console

@pgfox
Copy link
Copy Markdown
Contributor Author

pgfox commented Nov 6, 2017

@mtaylor I changed ActiveMQServerControlImpl#listAddresses(java.lang.String, int, int) to use
server.getManagementService().getResources(AddressControl.class)
rather than call
server.getPostOffice().getAddresses()
It was easier to get the memorySize and paging info from the AddressControl.
It seems to work fine but just wondering if it is a bad idea as you avoided it initially?

thanks
Pat

…erPage to the address summary in the addresses panel in the web console
@pgfox pgfox force-pushed the address_view_changes branch from d6d55af to be09f2c Compare November 7, 2017 07:09
@mtaylor
Copy link
Copy Markdown
Contributor

mtaylor commented Nov 15, 2017

@pgfox There is some overhead in managing MBeans (creating, destroying and cleaning up). The intent with the new console bits was to avoid any reliance on MBeans, so that going forward users could switch off MBean registration for certain object types and still be able to use management, via the ActiveMQServerControl. The overhead doesn't seem that large at first, but once we start getting into the 1000s of addresses or connections it can start becoming significant. Could you move the logic into a helper class or use the AddressInfo object instead?

@pgfox
Copy link
Copy Markdown
Contributor Author

pgfox commented Nov 20, 2017

Thanks @mtaylor. I will close this PR as it is the wrong approach, maybe followup later with another PR.

@pgfox pgfox closed this Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants