ARTEMIS-1798 DEBUG message bad write method arg count - fix#2006
Closed
sknot-rh wants to merge 1 commit intoapache:masterfrom
Closed
ARTEMIS-1798 DEBUG message bad write method arg count - fix#2006sknot-rh wants to merge 1 commit intoapache:masterfrom
sknot-rh wants to merge 1 commit intoapache:masterfrom
Conversation
| public class OpenWireProtocolManager implements ProtocolManager<Interceptor>, ClusterTopologyListener { | ||
| static { | ||
| // this is not really a property, needs to be ignored | ||
| FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(), "setUpInactivityParams"); |
Contributor
There was a problem hiding this comment.
@stanlyDoge Instead of that.. what about renaming the method to configureInactivityParams?
You wouldn't need to do anything with Beans.
Contributor
Author
|
@clebertsuconic Renamed. |
Contributor
|
nice one.. thanks.. will wait the check and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the logging level was set up to DEBUG, FluentPropertyBeanIntrospectorWithIgnores threw an exception at org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager#setUpInactivityParams because it was not really setting up any property. I have renamed this method to 'configureInactivityParams'. That avoids error message in DEBUG output.