ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel#2009
Merged
Conversation
The queue metrics were being decremented improperly because on iteration over the cancelled scheduled messages because the flag for fromMessageReferences was not set to false. Setting the flag to false skips over the metrics update which is what we want as the scheduled messages were never added to the message references in the first place so the metrics don't need updating
|
|
||
| queueControl.removeAllMessages(); | ||
|
|
||
| Assert.assertEquals(0, queueControl.getMessageCount()); |
Contributor
There was a problem hiding this comment.
in a lot of cases, I have had to change this to:
Wait.assertEquals(0, queueuControl::getMessageCount);
Are you sure this is reliable, non asynchronous?
Contributor
Author
There was a problem hiding this comment.
I think the removeAllMessages() call is synchronous but if it's an issue it's easy enough to switch out the assertion in the test
Contributor
There was a problem hiding this comment.
ok.. I will just merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The queue metrics were being decremented improperly because on iteration
over the cancelled scheduled messages because the flag for fromMessageReferences was not
set to false. Setting the flag to false skips over the metrics update
which is what we want as the scheduled messages were never added to the
message references in the first place so the metrics don't need updating