Skip to content

Conversation

@clebertsuconic
Copy link
Contributor

Same as Divert

@ldebello
Copy link
Contributor

ldebello commented May 29, 2019

@clebertsuconic I know you close #2682 because this ticket will solve it, but the changes here seems against the idea of leaving the responsibility to transform to reencode the message when adding property (#2634). Because as far as understand marking the message as changed in the divert will reencode it in the future (https://github.com/apache/activemq-artemis/pull/2686/files#diff-565f29f5e7c3e5234faff2352404eedbR129).

ldebello and others added 2 commits May 29, 2019 16:34
@clebertsuconic
Copy link
Contributor Author

@ldebello The Divert makes a copy of the message before anyway... I want to avoid a case where the broker changes the message unadvertadely . AMQP has a few specs that would be broken if I let that happen.

the way to go is to call messageChanged on the copy. and this is working fine, right?

I went further and looked at the Bridge which was also changing the root message instead of making a copy.

@asfgit asfgit merged commit 4fa2e75 into apache:master May 29, 2019
asfgit pushed a commit that referenced this pull request May 29, 2019
@ldebello
Copy link
Contributor

For my the change is ok, I am just point that now we can remove reencode from transformer because the message changed will do the trick, I copied your changes to my branch and include some application properties in the transformer without doing reencode and that works, also I remove the reencode from the test included in the PR mentioned above and that also works

@clebertsuconic clebertsuconic deleted the ARTEMIS-2361 branch July 30, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants