ARTEMIS-3105 large message file not closed on backup side#3435
Merged
asfgit merged 1 commit intoapache:masterfrom Feb 7, 2021
Merged
ARTEMIS-3105 large message file not closed on backup side#3435asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
CNNJYB
force-pushed
the
dev-largemessagefile-not-close-on-backup
branch
from
f404c77 to
69a0755
Compare
franz1981
approved these changes
Feb 6, 2021
Contributor
franz1981
left a comment
franz1981
left a comment
There was a problem hiding this comment.
LGTM in general, just thinking how to release it given that it introduce a new encoding/decoding form for the ReplicationLargeMessageEndMessage
| if (buffer.readableBytes() >= DataConstants.SIZE_LONG) { | ||
| pendingRecordId = buffer.readLong(); | ||
| } | ||
| isDelete = buffer.readBoolean(); |
Contributor
There was a problem hiding this comment.
can you check hasRemaining() on the buffer here, and return false by default?
We intend to keep live and replica the same version, but users do weird things... just in case please?
Contributor
|
LGTM.. only one small request on verifying the buffer having available bytes.. other than that I will run the whole test suite on Monday and if it's good I will merge it (after your amend please?) |
CNNJYB
force-pushed
the
dev-largemessagefile-not-close-on-backup
branch
from
69a0755 to
9c5ec1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We send a large number of large messages to the cluster, on the backup side, we found error message of too many open files.
We think that large message is released on live side but not released on the backup side, when receive the last chunk.