ARTEMIS-2870: Transfer connection close/failure listeners one by one … #3498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on reattachment Previously, when a session was reattached, all the close/failure listeners were removed from the old connection and set onto the new connection. This only worked when at most 1 session of the old connection was transferred: When the second session was transferred, the old connection already didn't contain any close/failure listeners anymore, and therefore the list of close/failure listeners was overwritten by an empty list for the new connection. Now, when a session is being transferred, it only transfers the close/failure listeners that belong to it, which are the session itself + the TempQueueCleanerUppers. Modified a test to check whether the sessions are failure listeners of the new connection after reattachment.
...c/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/ReattachTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on reattachment
Previously, when a session was reattached, all the close/failure listeners
were removed from the old connection and set onto the new connection.
This only worked when at most 1 session of the old connection was
transferred: When the second session was transferred, the old
connection already didn't contain any close/failure listeners anymore,
and therefore the list of close/failure listeners was overwritten by
an empty list for the new connection.
Now, when a session is being transferred, it only transfers the
close/failure listeners that belong to it, which are the session itself
Modified a test to check whether the sessions are failure listeners of
the new connection after reattachment.