ARTEMIS-4037 refactor MQTTRetainMessageManagerTest#4255
Closed
jbertram wants to merge 1 commit intoapache:mainfrom
Closed
ARTEMIS-4037 refactor MQTTRetainMessageManagerTest#4255jbertram wants to merge 1 commit intoapache:mainfrom
jbertram wants to merge 1 commit intoapache:mainfrom
Conversation
Commit 5a42de5 called my attention to this test. It really needs to be refactored because: - It belongs in the integration-tests module rather than the MQTT protocol module. - It is using a lot of non-standard components (e.g. EmbeddedJMSResource, Awaitility, etc.). - It is overly complicated (e.g. using its own MqttClientService). This commit resolves all those problems. The new implementation is quite a bit different but still equivalent. I reverted the original fix from ARTEMIS-2476 and the test still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 5a42de5 called my attention to this test. It really needs to be refactored because:
This commit resolves all those problems. The new implementation is quite a bit different but still equivalent. I reverted the original fix from ARTEMIS-2476 and the test still fails.