ARTEMIS-4332 Add management method to close stuck server sessions #4526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmellr
reviewed
Jun 28, 2023
Member
gemmellr
left a comment
gemmellr
left a comment
There was a problem hiding this comment.
Adding JIRA ref in PR title would be good.
...ain/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java
Show resolved
Hide resolved
...java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextUnitTest.java
Outdated
Show resolved
Hide resolved
...java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextUnitTest.java
Outdated
Show resolved
Hide resolved
brusdev
changed the title
brusdev
force-pushed
the
close_stuck_sessions
branch
from
e79c199 to
6714bb7
Compare
gemmellr
reviewed
Jul 3, 2023
Member
gemmellr
left a comment
gemmellr
left a comment
There was a problem hiding this comment.
LGTM other than the slight nitpick. I'd like someone else to review it too though.
...java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextUnitTest.java
Outdated
Show resolved
Hide resolved
brusdev
force-pushed
the
close_stuck_sessions
branch
from
6714bb7 to
a3a3f24
Compare
Member
Author
|
@gemmellr thanks for your review |
...ain/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java
Outdated
Show resolved
Hide resolved
brusdev
force-pushed
the
close_stuck_sessions
branch
from
a3a3f24 to
ce76651
Compare
...java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextUnitTest.java
Show resolved
Hide resolved
...java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextUnitTest.java
Show resolved
Hide resolved
...ain/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java
Outdated
Show resolved
Hide resolved
In rare cases a store operation could silently fails or starves, blocking the related server session and all delivering messages. Those server sessions can be closed adding a management method that cleans their operation context before closing them.
brusdev
force-pushed
the
close_stuck_sessions
branch
from
ce76651 to
9b598aa
Compare
Contributor
|
@brusdev only thing I could ask now is to verify if the new test over Core is failing in a loop or not? We had a few overCore tests failing in management because of noise from the Core itself (the testing framework itself is creating a connection and a session in the server's). Other than that I think we should merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTEMIS-4332 Add management method to close stuck server sessions
In rare cases a store operation could silently fails or starves, blocking the related server session and all delivering messages. Those server sessions can be closed adding a management method that cleans their operation context before closing them.
This PR also includes an optional commit to track store operations that would help to analyze heap dumps with stuck server sessions: ARTEMIS-4332 Add store operation trackers