small open wire change and another tweak#478
Merged
asfgit merged 2 commits intoapache:masterfrom Apr 21, 2016
Merged
Conversation
Contributor
Author
|
@howardgao @gaohoward It seems this is not really needed. I didn't find a real use for it at least.. all the tests are passing the same. Can you confirm please? (talking about 36350c2) |
Contributor
|
@clebertsuconic yeah I think you can just merge it. They are not needed anywhere in the clients as far as I can tell. However I'll run the tests just to make double sure (meaning don't wait for me). |
Contributor
Author
|
I already run the tests.. didn't make a difference |
Contributor
|
ok. It should be ok enough. |
clebertsuconic
force-pushed
the
master
branch
2 times, most recently
from
7f927eb to
e9ae616
Compare
Contributor
Author
|
The create durable queue is creating some test failures.. the change is good but there are tests failing (probably because they need to cleanup something... I will have to check out). Let me work on this first |
clebertsuconic
pushed a commit
to clebertsuconic/artemis
that referenced
this pull request
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.