ARTEMIS-497 Prevent 10 second stalls when closing an SSL connection#480
Closed
bgutjahr wants to merge 1 commit intoapache:masterfrom
Closed
ARTEMIS-497 Prevent 10 second stalls when closing an SSL connection#480bgutjahr wants to merge 1 commit intoapache:masterfrom
bgutjahr wants to merge 1 commit intoapache:masterfrom
Conversation
When NettyConnection.classSSLAndChannel is called from the EventLoop, waiting for the SSL handler to close will always take 10 seconds, because the sslCloseFuture is from a task that is scheduled with the same EventLoop. But since the EventLoop is a single threaded executor, it will only be executed after the current task is completed. Due to the single threaded nature of the EventLoop, all blocking calls should be avoided. Therefore, I removed both awaitUninterruptibly calls if the closing happens within an event loop tasks. As a side effect, the annoying server log timeout warnings will go away.
Contributor
|
nice one |
Contributor
|
@bgutjahr Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NettyConnection.classSSLAndChannel is called from the EventLoop,
waiting for the SSL handler to close will always take 10 seconds, because
the sslCloseFuture is from a task that is scheduled with the same
EventLoop. But since the EventLoop is a single threaded executor, it
will only be executed after the current task is completed.
Due to the single threaded nature of the EventLoop, all blocking calls
should be avoided. Therefore, I removed both awaitUninterruptibly calls
if the closing happens within an event loop tasks. As a side effect,
the annoying server log timeout warnings will go away.