ARTEMIS-125 Shared backup server with disabled scale down policy does…#5
Closed
mnovak1984 wants to merge 1 commit into
Closed
ARTEMIS-125 Shared backup server with disabled scale down policy does…#5mnovak1984 wants to merge 1 commit into
mnovak1984 wants to merge 1 commit into
Conversation
… not activate itself. If standalone backup server with shared has defined scale-down policy but it's disabled then backup does not activate. Problem is that server is checking only whether scale down is defined but if it's enabled. This causes that server.stop() is called and backup does not activate.
Contributor
|
@mnovak I had to do some rebasing (Justin changed some API) but I merged this already. Make sure you rebase your branch now as it's quite changed |
|
ActiveMQ-Artemis-PR-Build #377 FAILURE |
Author
|
Ok, I'll rebase and try again. |
Author
|
Did not notice that It's merged already. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… not activate.
If standalone backup server with shared has defined scale-down policy
but it's disabled then backup does not activate. Problem is that
server is checking only whether scale down is defined but not whether it's
enabled. This causes that server.stop() is called and backup does
not activate.