Use StandardCharsets more#515
Closed
scop wants to merge 1 commit intoapache:masterfrom
scop:standardcharsets
Closed
Use StandardCharsets more#515scop wants to merge 1 commit intoapache:masterfrom scop:standardcharsets
scop wants to merge 1 commit intoapache:masterfrom
scop:standardcharsets
Conversation
Contributor
|
@scop Hi, this looks good, there is a checkstyle error which is causing CI failure could you please update. Run with the "dev" maven profile to switch on check style.
|
Contributor
Author
|
PR updated and force-pushed. Hopefully it passes now, |
Contributor
|
@scop you should probably use mvn install -Pdev instead of compile. There is a snapshot updated daily when there are committs, and maven will check for updates daily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.