Skip to content

[AMQNET-851] Support amqps uri schemas #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[AMQNET-851] Support amqps uri schemas #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5555136
[AMQNET-851] Support amqps uri schemas
davidvoit Oct 27, 2025
349c999
[AMQNET-851] Add support to failover uri
davidvoit Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/nms-api/NMSConnectionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ static NMSConnectionFactory()
new ProviderFactoryInfo("Apache.NMS.ZMQ", "Apache.NMS.ZMQ.ConnectionFactory");
schemaProviderFactoryMap["amqp"] =
new ProviderFactoryInfo("Apache.NMS.AMQP", "Apache.NMS.AMQP.ConnectionFactory");
schemaProviderFactoryMap["amqps"] =
new ProviderFactoryInfo("Apache.NMS.AMQP", "Apache.NMS.AMQP.ConnectionFactory");
schemaProviderFactoryMap["failover"] =
Copy link
Contributor

@Havret Havret Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if someone wants to use failover with open-wire?

Copy link
Author

@davidvoit davidvoit Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be activemq:failover then? We could also implement a second level lookup if needed. look for tcp/ssl or amqp/amqps

Copy link
Author

@davidvoit davidvoit Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But failover: are currently so or so not working. I think it would be fine to conenect it to amqp and go with activemq:failover for openwire as the new default. What do you think, should we write some new uri parsind and decsision logick or would this new default be fine?

new ProviderFactoryInfo("Apache.NMS.AMQP", "Apache.NMS.AMQP.ConnectionFactory");
}

/// <summary>
Expand Down