Skip to content

Conversation

@liuxiran
Copy link
Contributor

@liuxiran liuxiran commented Oct 3, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

release version 2.9.0, after this version released, APISIX Dashboard can work together with APISIX 2.10.0 There may be a lack of functionality

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2021

Codecov Report

Merging #2154 (0e85347) into master (321a195) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2154   +/-   ##
=======================================
  Coverage   69.59%   69.59%           
=======================================
  Files         187      187           
  Lines        7137     7137           
  Branches      823      823           
=======================================
  Hits         4967     4967           
  Misses       1883     1883           
  Partials      287      287           
Flag Coverage Δ
backend-e2e-test 47.20% <ø> (+0.07%) ⬆️
backend-e2e-test-ginkgo 48.97% <ø> (-0.14%) ⬇️
backend-unit-test 52.74% <ø> (ø)
frontend-e2e-test 68.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321a195...0e85347. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from bzp2010 October 4, 2021 23:57
Co-authored-by: Peter Zhu <starszcan@gmail.com>
@liuxiran
Copy link
Contributor Author

liuxiran commented Oct 8, 2021

https://github.com/apache/apisix-dashboard/pull/2154/checks?check_run_id=3833771098

@bzp2010 please help to check it when you have time, thanks a lot

* feat: add shell to wait for services

* fix: add apache license
@imjoey
Copy link
Member

imjoey commented Oct 8, 2021

@liuxiran one more question, is this dashboard 2.9.0 also an LTS version, along with APISIX 2.10.0 LTS? Thanks.

@liuxiran liuxiran merged commit ef1e2db into master Oct 8, 2021
@liuxiran
Copy link
Contributor Author

liuxiran commented Oct 8, 2021

@liuxiran one more question, is this dashboard 2.9.0 also an LTS version, along with APISIX 2.10.0 LTS? Thanks.

I agree with making dashboard 2.9.0 as an LTS version together with APISIX 2.10.0

let's @bzp2010 for the real plan , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants