feat(route): add publish and offline to route #451

liuxiran · 2020-09-07T14:48:17Z

Please answer these questions before submitting a pull request

Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
issue Feature：route publish management #437 fe , depends on pr feat: add publish status to route in manager api #450

Bugfix

Description
How to fix?

New feature or improvement

Describe the details and related test reports.

in frontend we add status to route:

add status in create route step1

choose enable, means to publish route(create route both in mysql and apisix), and the route can be use now;
choose disable, means to create route offline(create route onlyl in mysql), the route could not be used

in route table,we add status column, and add publish offline button

the published route could be offline with the offline button; and the offline route could be published with the publish button.

juzhiyuan · 2020-09-08T02:19:02Z

@membphis Please take a look at those screenshots above :D

moonming · 2020-09-08T03:59:08Z

choose enable, means to publish route(create route both in mysql and apisix), and the route can be use now;

it will be better if we can make it more clearly about status.
others UI looks good for me.

juzhiyuan · 2020-09-08T04:33:35Z

OK, if there have no other critical issues about UI, I will review the codes soon.

src/pages/Route/service.ts

src/pages/Route/transform.ts

src/pages/Route/typing.d.ts

src/pages/Route/components/Step1/MetaView.tsx

src/pages/Route/Create.tsx

juzhiyuan · 2020-09-08T12:00:20Z

This PR should wait for #450

src/pages/Route/service.ts

juzhiyuan · 2020-09-09T02:57:55Z

Waiting for #450 , DO NOT MERGE NOW.

liuxiran · 2020-09-09T03:12:50Z

choose enable, means to publish route(create route both in mysql and apisix), and the route can be use now;

it will be better if we can make it more clearly about status.

At the beginning we have considered: offline, designing, testing, published and other states, corresponding to published, all other states are kinds of offline status, or would it be better to change offline to designing? @moonming

moonming · 2020-09-09T03:41:07Z

You may have misunderstood what I mean. I hope the description here is more clear

liuxiran · 2020-09-09T03:56:38Z

You may have misunderstood what I mean. I hope the description here is more clear

How about published after creation here？or add a tooltip to label: publish?

moonming · 2020-09-09T04:29:52Z

LGTM Thanks, Ming Wen Twitter: _WenMing liuxiran <notifications@github.com> 于2020年9月9日周三上午11:56写道：

…

[image: 图片] <https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png> You may have misunderstood what I mean. I hope the description here is more clear How about published after creation here？ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZBKZQ7ZBSHHZJIBATJY3SE34IHANCNFSM4Q6LLBPQ> .

juzhiyuan · 2020-09-09T05:18:04Z

@liuxiran could add the description under that field using Form item :D

membphis · 2020-09-10T07:41:11Z

src/pages/Route/typing.d.ts

  // Request Body or Response Data for API
  type Body = {
    id?: number;
+    status: boolean;


do we need to add a boolean flag in route?

https://github.com/apache/apisix/blob/master/doc/admin-api.md#route

we'll remove mysql soon.

If moved status to abisix, it could be a good extension as a basis for route lifecycle management, and if not, status is only a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api :).

juzhiyuan · 2020-09-11T03:09:36Z

Please resolve those conflicts :D

* feat(route): add publish and offline to route * feat: trigger redeploy * feat: trigger redeploy * Update Create.tsx * fix: update refer to the code review * fix: init status default value * fix: add a help msg to status Form.Item Co-authored-by: 琚致远 <juzhiyuan@apache.org>

* feat: preview pluginchart (#456) * feat: added pluginchart preview in route step4 * feat: change PluginChart to PluginOrchestration * add tools to check ASF headers in code files. (#454) * chore: remove unnecessary license file (#462) * remove unnecessary license file * remove unnecessary license file for `api7 dashboard` * Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file. (#461) * Increase the checking of .conf and .toml files. * Skip the check of dag-to-lua-1.1/README.md file * Put the "run Makefile" check before "get lua lib". * Put the "run Makefile" check before "get lua lib". * Put the "run Makefile" check before "get lua lib". Co-authored-by: lin <lin@MBPro.local> * ci: Add lint (#455) Co-authored-by: Rapiz <code@rapiz.me> * Feat: dashboard support route group (#433) * feat: route group UI * feat(route-ui): add routegroup when create route * fix: add routegroup to route list * fix: support add routegroup together with route * fix: route path define error * feat: trigger redeploy * fix: update i18n key Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feature:Independent license check operation file. (#465) * feat: support ungroup in manager api (#460) * feat: support ungroup in manager api * fix: synchronize route group to route * fix: update test case * feat: add publish status to route in manager api (#450) * feat: add publish status to route in manager api * fix: update publish and offline route * feat: add route publish test module * fix: synchronize content for route publish/offline * feat(route): add publish and offline to route (#451) * feat(route): add publish and offline to route * feat: trigger redeploy * feat: trigger redeploy * Update Create.tsx * fix: update refer to the code review * fix: init status default value * fix: add a help msg to status Form.Item Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feat: remove netlify (#472) * fix: host should not be required (#477) * feat: added new plugin dependency (#475) * feat: added new plugin dependency * feat: omit shadow var * feat: omit shadow var * fix: host should not be required (#479) * fix: host should not be required * feat: remove required rule * feat: Route debug (#485) * feat: new api get route and apisix url * feat: online debug * fix: update refer to the review, fix logical error as well * fix: rename getRouteWithApisixUrl * feat: update plugin (#482) * feat: improve route (#483) * feat: improve step1 * feat: improve step2 * feat: improve createStep4 * feat: improve transform * fix: event loop * feat: clean code * fix: lost route_group info when enable redirect * feat: UI improve * fix: checkHostWithSSL with empty hosts * Update Create.tsx Co-authored-by: Firstsawyou <52862365+Firstsawyou@users.noreply.github.com> Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com> Co-authored-by: lin <lin@MBPro.local> Co-authored-by: Rapiz <contact@rapiz.me> Co-authored-by: Rapiz <code@rapiz.me> Co-authored-by: liuxiran <belovedxixi@126.com> Co-authored-by: 琚致远 <juzhiyuan@apache.org>

juzhiyuan requested review from bzp2010, juzhiyuan and membphis September 7, 2020 17:11

moonming approved these changes Sep 8, 2020

View reviewed changes

LiteSun approved these changes Sep 8, 2020

View reviewed changes

juzhiyuan requested changes Sep 8, 2020

View reviewed changes

bzp2010 approved these changes Sep 8, 2020

View reviewed changes

juzhiyuan reviewed Sep 9, 2020

View reviewed changes

src/pages/Route/service.ts Show resolved Hide resolved

juzhiyuan approved these changes Sep 9, 2020

View reviewed changes

membphis reviewed Sep 10, 2020

View reviewed changes

liuxiran and others added 7 commits September 11, 2020 11:15

feat(route): add publish and offline to route

1f986c8

feat: trigger redeploy

7561b49

feat: trigger redeploy

3618172

Update Create.tsx

804b9a5

fix: update refer to the code review

8afc906

fix: init status default value

672be20

fix: add a help msg to status Form.Item

29b6ee5

liuxiran force-pushed the route_status_fe branch from 3253a87 to 29b6ee5 Compare September 11, 2020 05:52

juzhiyuan merged commit 13b5f0c into apache:master Sep 15, 2020

feat(route): add publish and offline to route #451

feat(route): add publish and offline to route #451

Uh oh!

Conversation

liuxiran commented Sep 7, 2020

Bugfix

New feature or improvement

Uh oh!

juzhiyuan commented Sep 8, 2020

Uh oh!

moonming commented Sep 8, 2020

Uh oh!

juzhiyuan commented Sep 8, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juzhiyuan commented Sep 8, 2020

Uh oh!

Uh oh!

juzhiyuan commented Sep 9, 2020

Uh oh!

liuxiran commented Sep 9, 2020

Uh oh!

moonming commented Sep 9, 2020

Uh oh!

liuxiran commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moonming commented Sep 9, 2020 via email

Uh oh!

juzhiyuan commented Sep 9, 2020

Uh oh!

membphis Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

liuxiran Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juzhiyuan commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

liuxiran commented Sep 9, 2020 •

edited

Loading

liuxiran Sep 11, 2020 •

edited

Loading