Skip to content

Conversation

@tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented May 26, 2021

  1. add test cases about filter
  2. fix bug about filter chain

2. fix bug about encode filter chain
@tzssangglass
Copy link
Member Author

@dmsolr @spacewander pls review

dmsolr
dmsolr previously approved these changes May 27, 2021
@nic-chen
Copy link
Member

@dmsolr
Please help review, I am not familiar with the specific logic.
If there is OK, we could merge it.

Copy link
Member

@dmsolr dmsolr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacewander spacewander merged commit 88c0c26 into apache:main May 27, 2021
@tzssangglass tzssangglass deleted the filter_test_cases branch June 2, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants