-
Notifications
You must be signed in to change notification settings - Fork 588
Closed
Description
Issue description
When we set upstream in dashboard ,the value of "upstream.pass_host" not be set, after that we set the nodes with domain, the domain value should be set to the backend node, but it not be set. because of the pass_host default value is pass( ref: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L360 ), it can not execute the node host set logical(ref: https://github.com/apache/apisix/blob/master/apisix/init.lua#L306-L327 and https://github.com/apache/apisix/blob/master/apisix/init.lua#L467-L473). I have fixed it change the upstream default value to node, I think it is not a good idea, we should add the config in dashboard ui 2.0.
Environment
- apisix version (cmd:
apisix version): - OS: (cmd:
uname -a) - OpenResty / Nginx version: (cmd:
nginx -Voropenresty -V)
Minimal test code / Steps to reproduce the issue
What's the actual result? (including assertion message & call stack if applicable)
What's the expected result?
Metadata
Metadata
Assignees
Labels
No labels