Skip to content

feat: Date and timestamp trunc with format array#94

Merged
sunchao merged 1 commit intoapache:mainfrom
parthchandra:date_time_trunc_fmt_array
Feb 22, 2024
Merged

feat: Date and timestamp trunc with format array#94
sunchao merged 1 commit intoapache:mainfrom
parthchandra:date_time_trunc_fmt_array

Conversation

@parthchandra
Copy link
Copy Markdown
Contributor

feat: date and timestamp trunc with format array

Which issue does this PR close?

Closes #93

Rationale for this change

Compatibility with Spark

What changes are included in this PR?

Implements support for the format parameter to be an array.

How are these changes tested?

Adds additional unit tests

feat: date and timestamp trunc with format array
@parthchandra parthchandra requested a review from sunchao February 22, 2024 17:35
Copy link
Copy Markdown
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has been reviewed internally.

@parthchandra
Copy link
Copy Markdown
Contributor Author

@viirya thank you for the approval (and review). Will wait for other comments and ci before merging.

Copy link
Copy Markdown
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending CI)

@sunchao sunchao changed the title feat: date and timestamp trunc with format array (#1438) feat: date and timestamp trunc with format array Feb 22, 2024
@sunchao sunchao changed the title feat: date and timestamp trunc with format array feat: Date and timestamp trunc with format array Feb 22, 2024
@sunchao sunchao merged commit b6a1407 into apache:main Feb 22, 2024
@sunchao
Copy link
Copy Markdown
Member

sunchao commented Feb 22, 2024

Merge, thanks

@parthchandra parthchandra deleted the date_time_trunc_fmt_array branch January 14, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date and timestamp trunc should support an array of formats

3 participants