Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Oct 16, 2021

Which issue does this PR close?

refactor datafusion lit function to allow different types

Closes #1131

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist force-pushed the python-refactor-lit branch from f8f0143 to 6c70f15 Compare October 16, 2021 09:53
@jimexist jimexist changed the title refactor datafusion lit function to allow different types refactor datafusion python lit function to allow different types Oct 16, 2021
@jimexist jimexist requested review from alamb and houqp October 16, 2021 10:13
@alamb
Copy link
Contributor

alamb commented Oct 16, 2021

This looks cool -- thank you I'll plan to review it tomorrow

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add boolean type too?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too -- bool is a good suggestion from @houqp

Another good set might be timestamps (datetime.date, etc) but perhaps we can add those as a separate PR

(nice tests, btw)

@jimexist jimexist merged commit 4b15fa5 into apache:master Oct 17, 2021
@jimexist jimexist deleted the python-refactor-lit branch October 17, 2021 14:42
@houqp houqp added the enhancement New feature or request label Nov 4, 2021
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
* Update cargo lock for ffi example

* Running cargo update

* Bump tokio to 1.45

* Bump object store

* Bump astral

* Prepare for 47 release

* Minor: clippy update warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datafusion python function lit only accepts i32 values

3 participants