-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix lost filters and projections in ParquetExec, CSVExec etc #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // normalize newlines (output on windows uses \r\n) | ||
| let actual_output = actual_output.replace("\r\n", "\n"); | ||
| let mut actual_output = actual_output.replace("\r\n", "\n"); | ||
| actual_output.retain(|x| !x.is_ascii_whitespace()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everytime changing explain struct will add whitespace in output.
Add this filter will make this test pass.
yjshen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ted-Jiang !
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ted-Jiang and @yjshen -- this looks great
liukun4515
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xudong963
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ted-Jiang
Which issue does this PR close?
Thanks for @yjshen give this advice ❤️.
Closes #2073.
Rationale for this change
Before:
Now:
What changes are included in this PR?
Are there any user-facing changes?