Merged
Conversation
viirya
approved these changes
Jul 1, 2022
alamb
approved these changes
Jul 1, 2022
| &mut docs, | ||
| "| {} | {} | {} | {} |", | ||
| config.key, config.data_type, config.default_value, config.description | ||
| ); |
Contributor
There was a problem hiding this comment.
Is there a reason to not use unwrap() here (in case of error)? I don't think it really matters as if writeln! fails writing to a String there are likely to be big problems.
so like
writeln(&mut docs, ....).unwrap()
Contributor
Author
There was a problem hiding this comment.
got it @alamb
I can do this enhancement with follow-up pr.
Contributor
|
I added some comments on the description so it is clear why this change is needed. THanks @liukun4515 |
Contributor
|
Merging to unblock other pRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NA
Rationale for this change
Looks like clippy is failing on PRs -- for example: https://github.com/apache/arrow-datafusion/runs/7146009434?check_suite_focus=true
Likely due to a new rust version being released: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1620-2022-06-30
What changes are included in this PR?
Are there any user-facing changes?