Skip to content

Fix date_part/extract functions to support now()#4548

Merged
alamb merged 2 commits intoapache:masterfrom
comphead:date_part_now
Dec 9, 2022
Merged

Fix date_part/extract functions to support now()#4548
alamb merged 2 commits intoapache:masterfrom
comphead:date_part_now

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Dec 7, 2022

Which issue does this PR close?

Closes #3096.

Rationale for this change

See #3096

What changes are included in this PR?

Bugfix for extract/date_part to work with functions

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Dec 7, 2022
@comphead
Copy link
Contributor Author

comphead commented Dec 7, 2022

@waitingkuo please check the PR

@comphead comphead changed the title Date part now Fix date_part/extract functions to support now() Dec 7, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @comphead

@alamb alamb merged commit d67bb57 into apache:master Dec 9, 2022
@comphead comphead deleted the date_part_now branch January 1, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date_part does't work for now()

2 participants