Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 25, 2023

Which issue does this PR close?

Part of #4495

Rationale for this change

Goal is to make datafusion easier to maintain (e.g. these tests can be updated with sqllogictest --complete)

What changes are included in this PR?

Port a bunch of lines of rust code to sqllogictest script

Are these changes tested?

Yes

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Feb 25, 2023
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels Feb 25, 2023
@jackwener
Copy link
Member

https://github.com/apache/arrow-datafusion/actions/runs/4269432821/jobs/7432635940

past window.slt exist unstable test, maybe we can resolve in this PR?

@alamb
Copy link
Contributor Author

alamb commented Feb 25, 2023

Added a fix in 3c469cc hopefully

Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for tidying up these tests 👍

@alamb alamb merged commit cb09142 into apache:main Feb 26, 2023
@ursabot
Copy link

ursabot commented Feb 26, 2023

Benchmark runs are scheduled for baseline = 69503ea and contender = cb09142. cb09142 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants