Skip to content

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Apr 23, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

#6099

What changes are included in this PR?

Add sqllogicaltest about GROUPBY.

A small part in https://github.com/gregrahn/sqllogictest

Are these changes tested?

Add test

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Apr 23, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a good test to run in the pg_compat suite too.

Thanks @jackwener

-1770
-1830

# TODO: WRONG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a reference to the ticket here too?

Suggested change
# TODO: WRONG
# TODO: WRONG
# https://github.com/apache/arrow-datafusion/issues/6099

28
82

# TODO: WRONG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO: WRONG
# TODO: WRONG
# https://github.com/apache/arrow-datafusion/issues/6099

@jackwener jackwener merged commit 1a277ac into apache:main Apr 24, 2023
@jackwener jackwener deleted the test branch April 24, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants