refactor: Expr::ScalarFunction to use a struct #6281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
reviewed
May 8, 2023
| #[derive(Clone, PartialEq, Eq, Hash)] | ||
| pub struct ScalarFunction { | ||
| /// The function | ||
| pub fun: built_in_function::BuiltinScalarFunction, |
Contributor
There was a problem hiding this comment.
I would love, long term, to remove the difference between ScalarFunction and ScalarUDF (aka have a single way of calling functions for built in and extension functions)
alamb
approved these changes
May 8, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup to me -- thank you @jackwener
alamb
approved these changes
May 8, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup to me -- thank you @jackwener
Member
Author
|
Thanks @alamb review. |
Member
Author
|
Because there is a following PR to refactor ScalarUDF. So, I merge this PR to continue #6284. (otherwise, it will cause conflict) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #2175 and #3807.
Rationale for this change
Continuing the work outlined in #3807 to bring
Exprvariants more in line withLogicalPlanvariants.What changes are included in this PR?
Refactors
Expr::ScalarFunctionto use a struct.Are there any user-facing changes?
No