[Minor], Bug Fix: Add empty ordering check at the source. #7230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
At the projection of the source, we keep track of ordering as long as they are used in the query.
Consider table below
which satisfies ordering
a ASC, b ASCandc ASC.If we run the query below on this table.
since, only column
cis used. We will not keep track of orderinga ASC, b ASC. However, during projection of orderingsempty vectors are still added to output ordering. Since, first entry in among alternative orderings is output_ordering. Output ordering of the
CsvExecis empty.In this PR, we add emptiness check, with this check we no longer store empty orderings(after projection) at the source. After this PR output ordering of the
CsvExecis no longer empty.What changes are included in this PR?
Are these changes tested?
Yes, new tests are added.
Are there any user-facing changes?