Minor: move datasource statistics code into its own module #7391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 23, 2023
| }) | ||
| .collect() | ||
| } | ||
| pub use statistics::get_statistics_with_limit; |
Contributor
Author
There was a problem hiding this comment.
This follows the existing visibility -- there is no change in behavior.
yjshen
approved these changes
Aug 23, 2023
Contributor
Author
|
Thank you for the review @yjshen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I am just trying to clean up the code, and I ran into this code that was in need of a home while doing so
What changes are included in this PR?
Move statistics code for datasource into its own module
Are these changes tested?
checked by compiler
Are there any user-facing changes?