Fix Decimal256 scalar display string in sqllogictest #7404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The pyarrow failure is unrelated: |
Contributor
|
I believe CI will pass after merging up from |
viirya
force-pushed
the
decimal256_minor
branch
from
138d77c to
3b46de5
Compare
alamb
approved these changes
Aug 25, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
makes sense to me - thank you!
Member
Author
|
Thanks @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
A followup to #7048.
Rationale for this change
In #7048, one question is the display string of Decimal256 scalar is different to Decimal128 in sqllogictest. This patch fixes it.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?