Skip to content

Update example-usage.md to remove reference to simd and rust nightly.#9677

Merged
alamb merged 5 commits intoapache:mainfrom
Omega359:main
Mar 18, 2024
Merged

Update example-usage.md to remove reference to simd and rust nightly.#9677
alamb merged 5 commits intoapache:mainfrom
Omega359:main

Conversation

@Omega359
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Minor doc update

Rationale for this change

Doc cleanup

What changes are included in this PR?

example usage doc cleanup.

Are these changes tested?

Nothing to test.

Are there any user-facing changes?

@Omega359 Omega359 marked this pull request as ready for review March 18, 2024 15:02
Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @Omega359
I checked https://docs.rs/base64-simd/latest/base64_simd/ which we use in DF and they dont require nightly

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 18, 2024

I think arrow-rs used to have a simd feature that required nightly, but the auto vectorization of the rust compiler is now good enough there is no need to do it manually.

@alamb alamb added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Mar 18, 2024
@alamb alamb merged commit c0a21b2 into apache:main Mar 18, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 18, 2024

Thanks @comphead and @Omega359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants