Skip to content

Conversation

@CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Sep 26, 2025

What's Changed

Moves integration tests to the latest version of the System.CommandLine package. Also cleans up some small preexisting formatting issues which the linter caught this time even though they were present before.

Closes apache/arrow-go#3.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the System.CommandLine package to the latest version and refactors the command-line interface code to use the newer API patterns. The changes migrate from the beta versions to a release candidate version and update the code to match the new API structure.

  • Updates System.CommandLine package from beta versions to 2.0.0-rc.1.25451.107
  • Refactors command-line option declarations to use object initializer syntax
  • Migrates from CommandHandler.Create to manual parsing with ParseResult.GetValue

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/Apache.Arrow.IntegrationTest/Program.cs Updates command-line parsing to use new API with explicit option declarations and manual parsing
test/Apache.Arrow.IntegrationTest/Apache.Arrow.IntegrationTest.csproj Updates System.CommandLine package version from beta1 to rc.1
test/Apache.Arrow.Flight.IntegrationTest/Program.cs Migrates from SetHandler to SetAction and updates command structure for new API
test/Apache.Arrow.Flight.IntegrationTest/Apache.Arrow.Flight.IntegrationTest.csproj Updates System.CommandLine package version from beta4 to rc.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CurtHagenlocher
Copy link
Contributor Author

@kou, I think the integration tests are failing for infrastructure reasons rather than as a result of this change -- especially because this failure model looks familiar -- but I'm not sure.

@kou
Copy link
Member

kou commented Sep 27, 2025

I opened apache/arrow#47673 for it.

@CurtHagenlocher
Copy link
Contributor Author

I opened apache/arrow#47673 for it.

Thanks; it looks like this is impacting all test runs so I'm going to go ahead and commit this PR as I don't believe it to be related.

@CurtHagenlocher CurtHagenlocher merged commit 16524ff into apache:main Sep 27, 2025
20 of 24 checks passed
@CurtHagenlocher CurtHagenlocher deleted the GH-3 branch October 1, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update license information

2 participants