cookie test: use maps.Equal instead of reflect.DeepEquals#544
Closed
pixelherodev wants to merge 1 commit intoapache:mainfrom
Closed
cookie test: use maps.Equal instead of reflect.DeepEquals#544pixelherodev wants to merge 1 commit intoapache:mainfrom
pixelherodev wants to merge 1 commit intoapache:mainfrom
Conversation
This is a drive-by patch; the test was failing for the other optimization, and I noticed this when I went to take a look and figured I'd just send the patch.
Contributor
Author
|
Just going to add this to the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a drive-by patch; the test was failing for the other optimization, and I noticed this when I went to take a look and figured I'd just send the patch.
Rationale for this change
map.Equals, for two values known to both be of type map[string]string, is a strictly faster and smaller operation than reflect.DeepEquals. This patch isn't really necessary, since it's only for a test, but it's good practice.
Are these changes tested?
The test is passing on my machine, yes.
Are there any user-facing changes?
No