-
Notifications
You must be signed in to change notification settings - Fork 69
Test on Julia pre instead of Julia nightly #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 87.43% 86.93% -0.51%
==========================================
Files 26 27 +1
Lines 3288 3398 +110
==========================================
+ Hits 2875 2954 +79
- Misses 413 444 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about removing _julia in file name?
It seems that it's redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 978ae20
|
Hmm. It seems that our jobs got stuck like #572 (comment) : https://github.com/apache/arrow-julia/actions/runs/18889408411/job/53929226376?pr=574#step:6:217 There are no failed jobs. |
|
It looks like there are failures on Julia 1.12.2. From a local run: # 126: Test Failed at /home/phillip/Work/arrow-julia/test/runtests.jl:391
Expression: tt.a == [1, 2, 3, 1, 2, 3, 4, 1, 2, 3, 4, 5]
Evaluated: [1, 2, 3, 1, 2, 3, 4, 1, 2, 3, 4, 4] == [1, 2, 3, 1, 2, 3, 4, 1, 2, 3, 4, 5] |
|
The failure seems unrelated to this PR and jobs are getting stuck on main too. Can this be merged? |
|
OK. Let's work on the time out problem as #571.
This is caused by multi-threading: https://github.com/apache/arrow-julia/actions/runs/19651602551/job/56279594532?pr=574#step:6:219 Let's work on it as #420. |
preinstead ofnightly#573