Generate new gold files using Arrow C++ 21.0.0 #114
Conversation
|
I'm trying to test this on apache/arrow#47729 |
|
@alamb @tustvold @paleolimbot @kou Is this ok? The monorepo integration tests have passed here |
|
Seems reasonable (doesn't remove or change files that other repos might be using already)! I was a little confused by the A more modern suffix convention is |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
I was a little confused by the 21.0.0 version but I suppose we just haven't regenerated those files in a long time.
How about cpp-21.0.0 instead of 21.0.0?
A more modern suffix convention is .arrow and .arrows (although I suppose that would break using these directly in archery?).
+1.
Sounds fine.
Yes, the problem is it would break the expectations of existing tools. I'm not sure it's worth introducing complication in Archery just to migrate to different file suffixes. |
pitrou
force-pushed
the
gold-files-21.0.0
branch
from
f640b9e to
fc7ad6e
Compare
Update the `testing` submodule to the latest contents as of apache/arrow-testing#114 . This adds "gold" IPC files generated by Arrow C++ 21.0.0.
### Rationale for this change Update the `testing` submodule to the latest contents as of apache/arrow-testing#114 . This adds "gold" IPC files generated by Arrow C++ 21.0.0. ### Are these changes tested? Yes, by existing Integration CI build. ### Are there any user-facing changes? No. * GitHub Issue: #47635 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
### Rationale for this change Update the `testing` submodule to the latest contents as of apache/arrow-testing#114 . This adds "gold" IPC files generated by Arrow C++ 21.0.0. ### Are these changes tested? Yes, by existing Integration CI build. ### Are there any user-facing changes? No. * GitHub Issue: apache#47635 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
3 participants
See apache/arrow#47635