ARROW-2542: [Plasma] Refactor object notification code #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Paul Taylor <paul.e.taylor@me.com> Closes apache#1751 from trxcllnt/ARROW-2312 and squashes the following commits: ac4759e <Paul Taylor> run test_js before test_integration
Arrow C++ users should use the same -NDEBUG flag as Arrow C++ itself. Author: Kouhei Sutou <kou@clear-code.com> Closes apache#1752 from kou/cpp-ndebug and squashes the following commits: 6a48486 <Kouhei Sutou> Add -NDEBUG flag to arrow.pc
`StructArray::field()` would not adjust the offset if the struct array was sliced, requiring error-prone fixup code in the caller. Author: Antoine Pitrou <antoine@python.org> Closes apache#1754 from pitrou/ARROW-2311-struct-array-slicing and squashes the following commits: f41ec7e <Antoine Pitrou> ARROW-2311: Fix struct array slicing
No need for our own reimplementation. Author: Antoine Pitrou <antoine@python.org> Closes apache#1748 from pitrou/ARROW-2309-std-make_unsigned and squashes the following commits: d4aa567 <Antoine Pitrou> Merge branch 'master' into ARROW-2309-std-make_unsigned ece4fa4 <Antoine Pitrou> ARROW-2309: Use std::make_unsigned
…rs do not have to remember to define NDEBUG for release builds Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1756 from wesm/revert-mutable-data-release-build and squashes the following commits: 722273f <Wes McKinney> clang-format ce1e7dd <Wes McKinney> Add debug-only mutability check to Buffer::mutable_data 51098b4 <Wes McKinney> Revert Buffer::mutable_data to inline so that linkers do not have to remember to build with -DNDEBUG
…1758) Change-Id: I1e6ddc19a8ca9896e5a434011bd1faba1f24be12
I can confirm that arrow failed to build with `-DARROW_BOOST_VENDORED=ON` and builds successfully with this patch. Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#1760 from cpcloud/ARROW-2320 and squashes the following commits: 3deb24e <Phillip Cloud> ARROW-2320: Vendored Boost build does not build regex library
…he#1750) Change-Id: I381465e5bd5bc84851dfcb34e47ff2c284f14efc
It seems like using the same store socket name for different tests introduced race conditions between connecting clients and starting/stopping the plasma store for each tests. This PR should fix it. This should fix https://issues.apache.org/jira/browse/ARROW-2318 Author: Philipp Moritz <pcmoritz@gmail.com> Closes apache#1761 from pcmoritz/fix-plasma-test and squashes the following commits: ee53c31 <Philipp Moritz> fix linting 381410c <Philipp Moritz> run plasma store tests with unique socket
…TALL_LIBDIR is not $ARROW_HOME/lib Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#1762 from cpcloud/ARROW-2321 and squashes the following commits: e1bf383 <Phillip Cloud> ARROW-2321: Release verification script fails with if CMAKE_INSTALL_LIBDIR is not $ARROW_HOME/lib
Change-Id: I8c3682711f4b8ec0106de1233d50843a40b078a5
Change-Id: I825873650c8f736bdfc2533fdb380e6844323a2e
Change-Id: I2a71d5db1bf2e68e652784aeb3aa9877422f5bbd
cc @wesm Author: siddharth <siddharth@dremio.com> Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1767 from siddharthteotia/release_website and squashes the following commits: 2e21fd0 <Wes McKinney> Update _data/versions.yml 73e008c <siddharth> update install.md 244da6b <siddharth> 0.9.0 release update for website
**NOTE:** Some code generated files and assembler output from the LLVM compiler do not have the headers as they would be stripped each time code generation is rerun. These files are included so that the Go package is go-gettable without any additional build steps. Author: Stuart Carnie <stuart.carnie@gmail.com> Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1739 from stuartcarnie/sgc-go-arrow and squashes the following commits: 95b9b42 <Wes McKinney> Add new ci/travis_release_audit.sh script 2320777 <Wes McKinney> Split Apache RAT check into separate script, always run. Update rat_exclude_files.txt f00fb6f <Stuart Carnie> Rename title; add Apache copyright headers to markdown files f31d8ca <Stuart Carnie> Add Apache copyright headers 3e17fe4 <Stuart Carnie> Initial commit, before copyright update
This to go live tomorrow morning alongside the 0.9.0 release announcement Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1777 from wesm/ARROW-2340 and squashes the following commits: 3718bc1 <Wes McKinney> Update publication date to 3/22 416be48 <Wes McKinney> Add missing link 3f083e3 <Wes McKinney> Add blog post about Go code donation
Short and sweet. I know it's late, but if anyone would like to add anything please push directly to this branch or post a commit for me to cherry-pick Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1776 from wesm/ARROW-2336 and squashes the following commits: c843d7c <Wes McKinney> Update pub date 212cf21 <Wes McKinney> Add 0.9.0 release blog post
Change-Id: I81118996633814122c8ff606bc80aa9325832ece
Author: Antoine Pitrou <antoine@python.org> Closes apache#1773 from pitrou/ARROW-2333-boost-bundling and squashes the following commits: ad79a38 <Antoine Pitrou> ARROW-2333: Fix bundling boost with default namespace
Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#1774 from cpcloud/ARROW-2334 and squashes the following commits: de93189 <Phillip Cloud> ARROW-2334: Update boost to 1.66.0
Also:
- make UnionType.mode return a string ('sparse' or 'dense')
- make UnionType indexing return fields, not types (like StructType)
Author: Antoine Pitrou <antoine@python.org>
Closes apache#1778 from pitrou/ARROW-2341-python-union and squashes the following commits:
c215f9b <Antoine Pitrou> ARROW-2341: Improve pa.union() mode argument behaviour
Note this is shadowed by the specialized StringArray.from_buffers(). Author: Antoine Pitrou <antoine@python.org> Closes apache#1772 from pitrou/ARROW-2281-python-array-from-buffers and squashes the following commits: c6bf373 <Antoine Pitrou> Try to fix crashes a7f658e <Antoine Pitrou> ARROW-2281: Add Array.from_buffers()
Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#1779 from cpcloud/ARROW-2343 and squashes the following commits: 4cd9a7e <Phillip Cloud> ARROW-2343: Run mvn clean in API doc builds
Several types (bool, timestamp with a non-None timezone, floats) were unpicklable. Based on PR apache#1778. Author: Antoine Pitrou <antoine@python.org> Closes apache#1780 from pitrou/ARROW-2342-types-pickling and squashes the following commits: 4cda526 <Antoine Pitrou> ARROW-2342: Allow pickling more types
…to True Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#1781 from cpcloud/ARROW-2345 and squashes the following commits: a0ce689 <Phillip Cloud> ARROW-2345: Fix bundle exec and set sphinx nosidebar to True
…ng Java release artifacts This is a one-time setup, but may be a stumbling block for new release managers (it was for me after a clean install) Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1782 from wesm/ARROW-2322 and squashes the following commits: 7992832 <Wes McKinney> Add links about Maven configuration for Java release process
Quoting seems necessary only when going through the shell. Author: Antoine Pitrou <antoine@python.org> Closes apache#1783 from pitrou/ARROW-2346-multiple-pyarrow-cxxflags and squashes the following commits: 6599ab0 <Antoine Pitrou> ARROW-2346: Fix PYARROW_CXX_FLAGS with multiple options
Author: Antoine Pitrou <antoine@python.org> Closes apache#1770 from pitrou/ARROW-2331-python-indexing and squashes the following commits: aec1ef0 <Antoine Pitrou> Try to fix downcast errors 1a38451 <Antoine Pitrou> ARROW-2331: Fix indexing for negative or out-of-bounds indices
…tely In the scenario that the following are true, this prevents issues in the following case: * Arrow libraries built with static Boost linking, and we pass `--with-static-boost` to setup.py * Arrow libraries being bundled `--bundle-arrow-cpp` * Boost libraries cannot be found when building pyarrow Right now if `--bundle-arrow-cpp` is passed, then `-DPYARROW_BUNDLE_BOOST=ON` is passed to CMake. Related to issues in apache/arrow-dist#23 Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1786 from wesm/ARROW-2349 and squashes the following commits: 4b5d13e <Wes McKinney> Opt in to bundling Boost separately
Author: Li Jin <ice.xelloss@gmail.com> Closes apache#1788 from icexelloss/ARROW-1913 and squashes the following commits: 964cead <Li Jin> Add Java 8 profile
Add garrow_decimal128_negate(). Author: yosuke shiro <ys2014hs@gmail.com> Closes apache#2047 from shiro615/ARROW-2576-add-negate-functions and squashes the following commits: 7a63d00 [yosuke shiro] rename absolute_value to positive_value 815f449 [yosuke shiro] Add negate functions
There is a regression (*) in Pandas 0.23.0 that breaks test_parquet.py. Pandas does not have an actual "str" dtype anyway, so pass "object" instead. (*) pandas-dev/pandas#21083 Author: Antoine Pitrou <antoine@python.org> Closes apache#2051 from pitrou/ARROW-2589 and squashes the following commits: b581ef3 <Antoine Pitrou> ARROW-2589: Workaround regression in Pandas 0.23.0
As far as I can understand, the problem is due to both shared and static linking with libarrow. Some static std::string in libarrow.so would be destroyed twice at shutdown. Linking entirely statically seems to fix the issue. Author: Antoine Pitrou <antoine@python.org> Closes apache#2048 from pitrou/ARROW-2561 and squashes the following commits: 7a9d1b5 <Antoine Pitrou> Add comment and do not mention arrow_shared in static link libs 0b40b80 <Antoine Pitrou> ARROW-2561: Fix double free in cuda-test under code coverage
…ucing garbage data - Problem * Using object_get_requests_[object_id] will produce a lot of garbage data in PlasmaStore::return_from_get. During the measurement process, we found that there was a lot of memory growth in this point. - Solution * Use iterator instead of operator [] Author: senlin.zsl <senlin.zsl@antfin.com> Closes apache#2056 from wumuzi520/dev_slz and squashes the following commits: ccaab50 <senlin.zsl> Use map.find instead of operator to avoid producing garbage data
…endencies for development Open items - [x] Why is `py.test pyarrow` failing on plasma deps when script follows [docs](https://arrow.apache.org/docs/python/development.html#developing-on-linux-and-macos)? - [x] Should `/script/*.sh` use the same code as developer docs to avoid denormalization? - [x] Move docker image to Apache registry? - [x] Multiple container strategy possible, but overly complex. Requires exposing volume on one container as a mount point for a second container. Only speeds up user's first build. - [x] Are gcc/g++ 4.8 the ideal versions? - [x] Unit tests needed? - [x] Update README per resolution of above Author: Aneesh Karve <aneesh.karve@gmail.com> Closes apache#2016 from akarve/master and squashes the following commits: 5aec17a <Aneesh Karve> final PR feedback; README indendtation
After spending a non-trivial time wrestling with Cython and our build system, we're now able to generate and upload Python and Cython coverage results as part of a Travis-CI run (in addition to C++ coverage). Author: Antoine Pitrou <antoine@python.org> Closes apache#2050 from pitrou/ARROW-2574-cython-coverage and squashes the following commits: 4553185 <Antoine Pitrou> Remove leftover b1212a4 <Antoine Pitrou> Silence "unknown warning option" error on clang e1a5b4a <Antoine Pitrou> Disable ORC when building benchmarks 06b0665 <Antoine Pitrou> Try to fix Sphinx doc building 9b41d24 <Antoine Pitrou> Add nogil tracing 4014951 <Antoine Pitrou> ARROW-2574: Add Cython and Python code coverage
…resent Array instead of enum Author: Andy Grove <andygrove73@gmail.com> Closes apache#1971 from andygrove/refactor_rust_api_v2 and squashes the following commits: a04d66a <Andy Grove> cargo fmt with 1.26.0 f3f71dd <Andy Grove> Rename BufferArray to PrimitiveArray 10714a1 <Andy Grove> cargo fmt b2d9e42 <Andy Grove> add assertions to RecordBatch d577510 <Andy Grove> Remove need to clone array be3a981 <Andy Grove> cargo fmt 22f907a <Andy Grove> Renaming structs and traits and adding documentation 4add4f0 <Andy Grove> Revert "Add type coercion helper method" 51270de <Andy Grove> Add type coercion helper method cc40ba4 <Andy Grove> Removing macros, implemented min/max for arrays of primitives 01bc953 <Andy Grove> implement min/max for primitive array b2659b1 <Andy Grove> run cargo fmt with stable rust 66c016e <Andy Grove> use usize instead of i32 (except for list offsets) dbe49a7 <Andy Grove> Rebase d1bfdca <Andy Grove> Merge branch 'master' of github.com:andygrove/arrow 2bae169 <Andy Grove> Refactor Rust API to use traits and generic to represent Array instead of enum 52de6a1 <Andy Grove> Merge branch 'master' of github.com:andygrove/arrow 0e2606b <Andy Grove> Merge remote-tracking branch 'upstream/master' d883da2 <Andy Grove> Merge remote-tracking branch 'upstream/master' 589ef71 <Andy Grove> Merge remote-tracking branch 'upstream/master' bd4fbb5 <Andy Grove> Merge remote-tracking branch 'upstream/master' 9c8a10a <Andy Grove> Merge remote-tracking branch 'upstream/master' 05592f8 <Andy Grove> Merge remote-tracking branch 'upstream/master' 8c0e698 <Andy Grove> Merge remote-tracking branch 'upstream/master' 31ef90b <Andy Grove> Merge remote-tracking branch 'upstream/master' 2f87c70 <Andy Grove> Fix build - add missing import
…of new buffer Currently when reallocating vectors, only the second half of the new buffer will be zeroed out assuming that it is doubled from the previous buffer and the first half is already populated or cleaned. This isn't the case if the vector had been cleared and the buffer is empty causing incorrect values in the new buffer if it was recycled from an old one. Added a new test with a ListVector that should reuse a previous buffer after being cleared. Author: Bryan Cutler <cutlerb@gmail.com> Closes apache#2054 from BryanCutler/java-vector-realloc-clear-buffer-ARROW-2594 and squashes the following commits: 28b8095 <Bryan Cutler> added a comment about clear be3ee8f <Bryan Cutler> remove extra spaces 5a39790 <Bryan Cutler> zero out any newly allocated buffer bytes
We don't need to customize it.
Fixes an issue where serialization turns integers into longs in Python 2. ```python In [1]: import pyarrow as pa In [2]: value = 1 In [3]: type(value) Out[3]: int In [4]: serialized = pa.serialize(value) In [5]: deserialized = serialized.deserialize() In [6]: type(deserialized) Out[6]: long ``` Author: Peter Schafhalter <pschafhalter@berkeley.edu> Closes apache#2055 from pschafhalter/fix-python2-int-serialization and squashes the following commits: 7b96b67 <Peter Schafhalter> Fix bug with Python 3 C++ API 5d8ff26 <Peter Schafhalter> Add type checking in assert_equal d5e5e5d <Peter Schafhalter> Fix python2 integer serialization bug
Author: Philipp Moritz <pcmoritz@gmail.com> Closes apache#2063 from pcmoritz/fix-plasma-deprecated-const and squashes the following commits: b6e92f6 <Philipp Moritz> fix test 5e1d82b <Philipp Moritz> add test 469b59a <Philipp Moritz> fix deprecated PLASMA_DEFAULT_RELEASE_DELAY
Replace UniqueIDHasher with std::hash so that STL containers with ObjectID doesn't need to specify the compare function. This has already been done for Ray, this change applies it to Plasma. Author: Zhijun Fu <pingfu.fzj@antfin.com> Author: Zhijun Fu <zhijun.fu@outlook.com> Closes apache#2059 from zhijunfu/remove-UniqueIDHasher and squashes the following commits: 2498635 <Zhijun Fu> resolve review comments: remove const version of hash() d5b5169 <Zhijun Fu> remove UniqueIDHasher
Just a couple of trivial changes that got missed in the refactor: - Derive Eq trait for DataType and Field (because I rely on that as a user of this library) - ArrowPrimitiveType should NOT be implemented for strings Author: Andy Grove <andygrove73@gmail.com> Closes apache#2070 from andygrove/post_refactor_cleanup and squashes the following commits: 6b245a4 <Andy Grove> add accessor methods to ListArray 3289e3b <Andy Grove> Update examples 236fde8 <Andy Grove> Minor post-refactor cleanup 82765f9 <Andy Grove> Merge remote-tracking branch 'upstream/master' d1bfdca <Andy Grove> Merge branch 'master' of github.com:andygrove/arrow 52de6a1 <Andy Grove> Merge branch 'master' of github.com:andygrove/arrow 0e2606b <Andy Grove> Merge remote-tracking branch 'upstream/master' d883da2 <Andy Grove> Merge remote-tracking branch 'upstream/master' 589ef71 <Andy Grove> Merge remote-tracking branch 'upstream/master' bd4fbb5 <Andy Grove> Merge remote-tracking branch 'upstream/master' 9c8a10a <Andy Grove> Merge remote-tracking branch 'upstream/master' 05592f8 <Andy Grove> Merge remote-tracking branch 'upstream/master' 8c0e698 <Andy Grove> Merge remote-tracking branch 'upstream/master' 31ef90b <Andy Grove> Merge remote-tracking branch 'upstream/master' 2f87c70 <Andy Grove> Fix build - add missing import
Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#2069 from xhochy/remove-group-deprecated and squashes the following commits: 9b9e619 <Korn, Uwe> ARROW-2614: Remove 'group: deprecated' in Travis
Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#2068 from xhochy/ARROW-2613 and squashes the following commits: ec955c4 <Korn, Uwe> ARROW-2613: Update the gen_apidocs docker script
…atic method in parquet-cpp/src/parquet/arrow/reader.cc Author: Joshua Storck <joshua.storck@twosigma.com> Closes apache#2036 from joshuastorck/decimal_from_big_endian and squashes the following commits: e970c87 <Joshua Storck> Fixing lint errors 4cb4d89 <Joshua Storck> Adding Decimal::FromBigEndian, which was formerly a static method in parquet-cpp/src/parquet/arrow/reader.cc
Author: Philipp Moritz <pcmoritz@gmail.com> Closes apache#2073 from pcmoritz/fix-iterator and squashes the following commits: bec37f0 <Philipp Moritz> linting 820f9d6 <Philipp Moritz> update 6b80ddc <Philipp Moritz> docs 66a927c <Philipp Moritz> fix iterator invalidation
pitrou
reviewed
May 23, 2018
| /// remaining message is a serialized version of the object info. | ||
| /// | ||
| /// @param object_info The object info to be serialized | ||
| /// @return The object info buffer. It is the caller's responsibility to free |
There was a problem hiding this comment.
It would be nice to update the docstring, the @return part is currently outdated.
pitrou
reviewed
May 23, 2018
cpp/src/plasma/plasma.cc
Outdated
| auto notification = std::make_shared<std::vector<uint8_t>>( | ||
| sizeof(int64_t) + fbb.GetSize()); | ||
| *(reinterpret_cast<int64_t*>(notification->data())) = fbb.GetSize(); | ||
| memcpy(notification->data() + sizeof(int64_t), fbb.GetBufferPointer(), fbb.GetSize()); |
There was a problem hiding this comment.
If you're creating a message buffer rather than a vector of independent values, wouldn't it make more sense to return a std::string (or perhaps a shared pointer thereof)?
(edit: or even an Arrow buffer object)
https://issues.apache.org/jira/browse/ARROW-2116 https://issues.apache.org/jira/browse/ARROW-2115 This PR represents a first pass at implementing the IPC writers for binary stream and file formats in JS. I've also added scripts to do the `json-to-arrow`, `file-to-stream`, and `stream-to-file` steps of the integration tests. These scripts rely on a new feature in Node 10 (the next LTS version), so please update. My attempts to use a library to remain backwards-compatible with Node 9 were unsuccessful. I've only done the APIs to serialize a preexisting Table to stream or file formats so far. We will want to refactor this soon to support end-to-end streaming. Edit: Figured out why the integration tests weren't passing, fixed now 🥇 Author: ptaylor <paul.e.taylor@me.com> Author: Paul Taylor <paul.e.taylor@me.com> Author: lsb <leebutterman@gmail.com> Closes apache#2035 from trxcllnt/js-buffer-writer and squashes the following commits: 261a864 <ptaylor> Merge branch 'master' into js-buffer-writer 917c2fc <ptaylor> test the ES5/UMD bundle in the integration tests 7a346dc <ptaylor> add a handy script for printing the alignment of buffers in a table 4594fe3 <ptaylor> align to 8-byte boundaries only 1a9864c <ptaylor> read message bodyLength from flatbuffer object e34afaa <ptaylor> export the RecordBatchSerializer b765b12 <ptaylor> speed up integration_test.py by only testing the JS source, not every compilation target 4ed6554 <ptaylor> Merge branch 'master' of https://github.com/apache/arrow into js-buffer-writer f497f7a <ptaylor> measure maxColumnWidths across all recordBatches when printing a table 14e6b38 <ptaylor> cleanup: remove dead code df43bc5 <ptaylor> make arrow2csv support streaming files from stdin, add rowsToString() method to RecordBatch 7924e67 <ptaylor> rename readNodeStream -> readStream, fromNodeStream -> fromReadableStream, add support for reading File format efc7225 <ptaylor> fix perf tests a06180b <ptaylor> don't run JS integration tests in src-only mode when --debug=true ed85572 <ptaylor> fix instanceof ArrayBuffer in jest/node 10 2df1a4a <ptaylor> update google-closure-compiler, remove gcc-specific workarounds in the build a6a7ab9 <ptaylor> put test tables into hoisted functions so it's easier to set breakpoints a79334d <ptaylor> fix typo again after rebase 081fefc <ptaylor> remove bin from ts package.json ccaf489 <ptaylor> remove stream-to-iterator c0b88c2 <ptaylor> always write flatbuffer vectors 0be6de3 <ptaylor> use node v10.1.0 in travis d4b8637 <ptaylor> add license headers b52af25 <ptaylor> cleanup 3187732 <ptaylor> set bitmap alignment to 8 bytes if < 64 values af9f4a8 <ptaylor> run integration tests in node 10.1 de81ac1 <ptaylor> Update JSTester to be an Arrow producer now too 832cc30 <ptaylor> add more js integration scripts for creating/converting arrow formats 263d06d <ptaylor> clean up js integration script 78cba38 <ptaylor> arrow2csv: support reading arrow streams from stdin e75da13 <ptaylor> add support for reading streaming format via node streams 4e80851 <ptaylor> write correct recordBatch length 73a2fa9 <ptaylor> fix stream -> file, file -> stream, add tests 304e75d <ptaylor> fix magic string alignment in file reader, add file reader tests 402187e <ptaylor> add apache license headers db02c1c <ptaylor> Add an integration test for binary writer a242da8 <ptaylor> Add `Table.prototype.serialize` method to make ArrayBuffers from Tables da0f457 <ptaylor> first pass at a working binary writer, only arrow stream format tested so far 508f4f8 <ptaylor> add getChildAt(n) methods to List and FixedSizeList Vectors to be more consistent with the other nested Vectors, make it easier to do the writer a9d773d <ptaylor> move ValidityView into its own module, like ChunkedView is 85eb7ee <ptaylor> fix erroneous footer length check in reader 4333e54 <ptaylor> FileBlock constructor should accept Long | number, have public number fields 7fff99e <ptaylor> move IPC magic into its own module d98e178 <ptaylor> add option to run gulp cmds with `-t src` to run jest against the `src` folder direct aaec76b <ptaylor> fix @std/esm options for node10 18b9dd2 <lsb> Fix a typo efb840f <Paul Taylor> fix typo ae1f481 <Paul Taylor> align to 64-byte boundaries c8ba1fe <Paul Taylor> don't write an empty buffer for NullVectors 43c671f <Paul Taylor> add Binary writer 6522cb0 <Paul Taylor> fix Data generics for FixedSizeList ef1acc7 <Paul Taylor> read union buffers in the correct order dc92b83 <Paul Taylor> fix typo
fixed a few typo while reading the codes / javadocs. Author: bomeng <bmeng@us.ibm.com> Closes apache#2076 from bomeng/2630 and squashes the following commits: 9c6fb5a <bomeng> typo fix
This adds a convenience method to easily set values in `VarCharVector` using the friendly type `Text`. This allows the user to set values without having to think about the correct encoding. Text objects can be constructed from a String using the constructor `Text(String string)`. Extended existing test to set/get a `VarCharVector` using `Text` objects. Author: Bryan Cutler <cutlerb@gmail.com> Closes apache#2071 from BryanCutler/java-varchar-from-string-ARROW-2604 and squashes the following commits: 5579edb <Bryan Cutler> add set Text to VarCharVector
pcmoritz
force-pushed
the
modernize-io-code
branch
from
a765e5e
to
169b182
Compare
|
@pcmoritz this patch is a bit stale. Are there plans to rehabilitate it? |
|
@pcmoritz can this be closed until you have time to clean it up? |
|
@pcmoritz closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.