ARROW-2318: [Plasma] Run plasma store tests with unique socket#1761
Closed
pcmoritz wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-2318: [Plasma] Run plasma store tests with unique socket#1761pcmoritz wants to merge 2 commits intoapache:masterfrom
pcmoritz wants to merge 2 commits intoapache:masterfrom
Conversation
wesm
approved these changes
Mar 16, 2018
Member
wesm
left a comment
There was a problem hiding this comment.
+1
Seems like these tests are "outrunning" the Plasma store getting ready. No big deal, but these stderr warnings might be a tad aggressive
$ ./release/client_tests
[==========] Running 7 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 7 tests from TestPlasmaStore
[ RUN ] TestPlasmaStore.DeleteTest
Connection to IPC socket failed for pathname /tmp/store2961491687, retrying 50 more times
[ OK ] TestPlasmaStore.DeleteTest (103 ms)
[ RUN ] TestPlasmaStore.ContainsTest
Connection to IPC socket failed for pathname /tmp/store4069682055, retrying 50 more times
[ OK ] TestPlasmaStore.ContainsTest (103 ms)
[ RUN ] TestPlasmaStore.GetTest
Connection to IPC socket failed for pathname /tmp/store4275793320, retrying 50 more times
[ OK ] TestPlasmaStore.GetTest (103 ms)
[ RUN ] TestPlasmaStore.MultipleGetTest
Connection to IPC socket failed for pathname /tmp/store1316524434, retrying 50 more times
[ OK ] TestPlasmaStore.MultipleGetTest (104 ms)
[ RUN ] TestPlasmaStore.AbortTest
Connection to IPC socket failed for pathname /tmp/store764105752, retrying 50 more times
[ OK ] TestPlasmaStore.AbortTest (103 ms)
[ RUN ] TestPlasmaStore.MultipleClientTest
Connection to IPC socket failed for pathname /tmp/store2758522039, retrying 50 more times
[ OK ] TestPlasmaStore.MultipleClientTest (104 ms)
[ RUN ] TestPlasmaStore.ManyObjectTest
Connection to IPC socket failed for pathname /tmp/store3072601515, retrying 50 more times
[ OK ] TestPlasmaStore.ManyObjectTest (124 ms)
[----------] 7 tests from TestPlasmaStore (745 ms total)
[----------] Global test environment tear-down
[==========] 7 tests from 1 test case ran. (745 ms total)
[ PASSED ] 7 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like using the same store socket name for different tests introduced race conditions between connecting clients and starting/stopping the plasma store for each tests. This PR should fix it.
This should fix https://issues.apache.org/jira/browse/ARROW-2318